Skip to content

fix: fix tests that failed on FSC #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomaszurkan-optimizely merged 2 commits into from
Jul 29, 2020
Merged

fix: fix tests that failed on FSC #352

thomaszurkan-optimizely merged 2 commits into from
Jul 29, 2020

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Jul 28, 2020

add unit tests and fail invalid versions and prerelease is always less than release.

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner July 28, 2020 21:23
@coveralls
Copy link

coveralls commented Jul 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0004%) to 98.748% when pulling 477c1cc on fixSemVer into 9b68575 on master.

msohailhussain
msohailhussain approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 8fc101c into master Jul 29, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fixSemVer branch July 29, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 4 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thomaszurkan-optimizely @coveralls @msohailhussain @optimizely-codereview-bot